Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass.pygrass: Fixed E402 in vector/ #4715

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Conversation

arohanajit
Copy link
Contributor

Since libgis needed to be imported first, I put the all the imports intitally menioned after libgis in a function which I subsequently called in order to resolve flake8

Arohan Ajit and others added 3 commits November 18, 2024 11:17
@github-actions github-actions bot added Python Related code is in Python libraries labels Nov 18, 2024
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use # noqa and please remove the extra file.

@echoix
Copy link
Member

echoix commented Nov 19, 2024

If that extra file was a token used for something, you'd need to rotate it as it's now leaked.

@neteler neteler changed the title pygrass: Fixed E402 in vecto/ pygrass: Fixed E402 in vector/ Nov 19, 2024
Arohan Ajit added 2 commits November 19, 2024 14:22
@arohanajit arohanajit changed the title pygrass: Fixed E402 in vector/ grass.pygrass: Fixed E402 in vector/ Nov 19, 2024
python/grass/pygrass/vector/__init__.py Outdated Show resolved Hide resolved
python/grass/pygrass/vector/__init__.py Outdated Show resolved Hide resolved
echoix
echoix previously approved these changes Dec 10, 2024
@echoix
Copy link
Member

echoix commented Dec 10, 2024

@arohanajit There's also conflicts here when you have time

@echoix echoix added the conflicts/needs rebase Rebase to or merge with the latest base branch is needed label Dec 18, 2024
@echoix
Copy link
Member

echoix commented Dec 19, 2024

@arohanajit could you take a look and solve the conflicts

@arohanajit arohanajit requested a review from echoix December 19, 2024 21:01
@echoix echoix removed the conflicts/needs rebase Rebase to or merge with the latest base branch is needed label Dec 19, 2024
@echoix echoix enabled auto-merge (squash) December 19, 2024 21:26
@echoix echoix merged commit fce29ca into OSGeo:main Dec 19, 2024
26 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libraries Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants